Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: support pd dev #8140

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

tools: support pd dev #8140

wants to merge 1 commit into from

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Apr 30, 2024

What problem does this PR solve?

Issue Number: Ref #8135

$ ./bin/pd-dev --mode backup                                                                                                                                                                                  
$ ./bin/pd-dev --mode analysis --input ~/.tiup/data/UBOupkt/pd-0/pd.log --style transfer-counter --operator balance-region
$ ./bin/pd-dev --mode api --http-cases GetRegionStatus-1+1,GetMinResolvedTS-1+1 --client 1 --debug true                                                                                                       
$ ./bin/pd-dev --mode heartbeat --config=./tools/pd-dev/pd-heartbeat-bench/config-template.toml      
image

What is changed and how does it work?

  • support pd-dev to run all tools
  • refine tools code and structure

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and nolouch April 30, 2024 07:00
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (2fabb74) to head (1ed11a1).

Current head 1ed11a1 differs from pull request most recent head b9ff645

Please upload reports for the commit b9ff645 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8140      +/-   ##
==========================================
- Coverage   77.34%   77.33%   -0.02%     
==========================================
  Files         471      470       -1     
  Lines       61368    61313      -55     
==========================================
- Hits        47466    47417      -49     
+ Misses      10341    10319      -22     
- Partials     3561     3577      +16     
Flag Coverage Δ
unittests 77.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor

nolouch commented May 9, 2024

I think for those tools, perhaps we can learn something from [Carge Custom Commands](https://doc.rust-lang.org/cargo/reference/external-tools.html#custom-subcommands).

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp removed request for JmPotato and nolouch May 21, 2024 03:19
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants