Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: add check action when poll the opeators from opNotifierQueue (#8010) #8179

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8010

What problem does this PR solve?

Issue Number: Close #7992

What is changed and how does it work?

It add light check for polling the opeators from Controller::opNotifierQueue. 
For example, check whether the region has disappeared,check whether the version of region epoch has changed for merge-region operator.
It has the chance to cancel the operators from Controller::opNotifierQueue execept timeout. We can only cancel the operator by timeout mechanism before.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

TonsnakeLin added 5 commits May 15, 2024 09:39
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
Signed-off-by: TonsnakeLin <michael.p@pingcap.com.cn>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-8010-to-release-7.5 branch from fa17830 to ed93593 Compare May 15, 2024 09:39
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 15, 2024
Copy link
Contributor

ti-chi-bot bot commented May 15, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TonsnakeLin
Copy link
Contributor

/test ?

Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

@TonsnakeLin: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lhy1024
Copy link
Contributor

lhy1024 commented May 17, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 20, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented May 20, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ed93593

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5a3d21d into tikv:release-7.5 May 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants