-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiutil/middleware: add retry logic for obtaining PD leader in redirector #8216
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8216 +/- ##
==========================================
- Coverage 77.40% 77.33% -0.07%
==========================================
Files 471 471
Lines 61456 61478 +22
==========================================
- Hits 47569 47544 -25
- Misses 10323 10377 +54
+ Partials 3564 3557 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
12419a8
to
1b580df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I was thinking that compared with retry in pd, will it be more reasonable to send a request to the leader directly and backoff on the client side?
I agree; client retry should be the most straightforward choice. However, considering that this PR only takes effect during the interval of PD leader re-election, a small internal retry attempt would be lighter and faster than having the client receive an error and then retry. The two are not in conflict. |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1b580df
|
Does it need to be picked to other branches? |
Let's observe the effect of this change for a period of time before cherry-picking. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #8142.
What is changed and how does it work?
Check List
Tests
Release note