Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/simulator: reduce range times #8318

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jun 21, 2024

What problem does this PR solve?

Issue Number: Ref #8135

What is changed and how does it work?

can reduce range times when in too many regions

for large cluster
image
before
image
after
image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

@HuSharp HuSharp requested review from nolouch and rleungx June 21, 2024 08:46
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-24 06:06:46.367537878 +0000 UTC m=+613332.853026710: ☑️ agreed by rleungx.
  • 2024-06-24 10:11:51.206559361 +0000 UTC m=+628037.692048190: ☑️ agreed by nolouch.

@HuSharp
Copy link
Member Author

HuSharp commented Jun 24, 2024

/test pull-integration-realcluster-test

Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2024

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6ae7b47 into tikv:master Jun 25, 2024
17 checks passed
@HuSharp HuSharp deleted the execute_regions branch June 25, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants