resource_control: allow configuration of the maximum retry time for the local bucket #8352

nolouch · 2024-07-02T08:09:41Z

What problem does this PR solve?

Issue Number: Close #8349

What is changed and how does it work?

resource_control: allow configuration of the maximum retry time for the local bucket
- Added config `ltb-token-rpc-max-delay`
- Increased default max delay from 500ms to 1s

Check List

Tests

Unit test
Integration test

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

…he local bucket Signed-off-by: nolouch <nolouch@gmail.com>

client/resource_group/controller/controller.go

JmPotato · 2024-07-02T09:43:12Z

client/resource_group/controller/controller.go

+			default:
+				select {


Suggested change

default:

select {

default:

}

select {

This can reduce one level of nesting.

I removed the changes, and will do it in another PR. Here only introduce the config. cc @JmPotato

JmPotato

The rest LGTM.

Signed-off-by: nolouch <nolouch@gmail.com>

HuSharp

rest LGTM

client/resource_group/controller/config.go

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2024-07-03T03:31:49Z

PTAL @JmPotato

ti-chi-bot · 2024-07-03T05:46:53Z

[LGTM Timeline notifier]

Timeline:

2024-07-02 10:06:08.903959745 +0000 UTC m=+1318895.389448577: ☑️ agreed by HuSharp.
2024-07-03 05:46:52.180557119 +0000 UTC m=+1389738.666045950: ☑️ agreed by JmPotato.

ti-chi-bot · 2024-07-03T06:56:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [HuSharp,JmPotato]
~~client/resource_group/controller/OWNERS~~ [niubell]
~~pkg/mcs/resourcemanager/server/OWNERS~~ [niubell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-07-04T04:11:52Z

In response to a cherrypick label: new pull request created to branch release-7.5: #8360.

ti-chi-bot · 2024-07-04T06:15:33Z

In response to a cherrypick label: new pull request created to branch release-8.1: #8361.

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

nolouch · 2024-07-04T06:21:14Z

/run-cherry-picker

ti-chi-bot · 2024-07-04T06:21:39Z

In response to a cherrypick label: new pull request created to branch release-8.2: #8362.

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-07-04T07:35:05Z

In response to a cherrypick label: new pull request created to branch release-7.1: #8364.

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com>

close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com>

…he local bucket (#8352) (#8364) close #8349 resource_control: allow configuration of the maximum retry time for the local bucket - Added config `ltb-token-rpc-max-delay` - Increased default max delay from 500ms to 1s Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>

…he local bucket (#8352) (#8360) close #8349 resource_control: allow configuration of the maximum retry time for the local bucket - Added config `ltb-token-rpc-max-delay` - Increased default max delay from 500ms to 1s Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: nolouch <nolouch@gmail.com>

…he local bucket (#8352) (#8361) close #8349 resource_control: allow configuration of the maximum retry time for the local bucket - Added config `ltb-token-rpc-max-delay` - Increased default max delay from 500ms to 1s Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: nolouch <nolouch@gmail.com>

close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com>

close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com> Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>

…he local bucket (#8352) (#8362) * resource_control: allow configuration of the maximum retry time for the local bucket Signed-off-by: nolouch <nolouch@gmail.com>

…he local bucket (#8352) (#8365) * client/controller: record context error and add slowlog about token bucket (#8344) (#8355) close #8343, ref #8349 client/controller: record context error and add slowlog about token bucket - record low process start time, and log it if it's too slow - record the context error Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local> * This is an automated cherry-pick of #8352 close #8349 Signed-off-by: nolouch <nolouch@gmail.com> Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local> --------- Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local> Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2024

nolouch force-pushed the export-config branch 2 times, most recently from 66da8b5 to 5a37dc6 Compare July 2, 2024 08:16

resource_control: allow configuration of the maximum retry time for t…

7ed3283

…he local bucket Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the export-config branch from 5a37dc6 to 7ed3283 Compare July 2, 2024 08:31

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Jul 2, 2024

nolouch requested review from JmPotato and HuSharp July 2, 2024 09:08

JmPotato reviewed Jul 2, 2024

View reviewed changes

client/resource_group/controller/controller.go Outdated Show resolved Hide resolved

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2024

JmPotato reviewed Jul 2, 2024

View reviewed changes

remove changes

5a383e2

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the export-config branch from 55f8e7b to 5a383e2 Compare July 2, 2024 09:47

Merge remote-tracking branch 'origin/master' into export-config

d7008e4

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 2, 2024

HuSharp reviewed Jul 2, 2024

View reviewed changes

client/resource_group/controller/config.go Outdated Show resolved Hide resolved

client/resource_group/controller/config.go Show resolved Hide resolved

address

8283d6f

Signed-off-by: nolouch <nolouch@gmail.com>

HuSharp approved these changes Jul 2, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 2, 2024

JmPotato approved these changes Jul 3, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2024

niubell approved these changes Jul 3, 2024

View reviewed changes

ti-chi-bot bot added the approved label Jul 3, 2024

ti-chi-bot bot merged commit 6b25787 into tikv:master Jul 3, 2024
24 checks passed

nolouch deleted the export-config branch July 3, 2024 07:06

ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 4, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

a5c4b61

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 4, 2024

resource_control: allow configuration of the maximum retry time for the local bucket (#8352) #8360

Merged

ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 4, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

6c81ccc

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 4, 2024

resource_control: allow configuration of the maximum retry time for the local bucket (#8352) #8361

Merged

nolouch added the needs-cherry-pick-release-8.2 label Jul 4, 2024

ti-chi-bot mentioned this pull request Jul 4, 2024

resource_control: allow configuration of the maximum retry time for the local bucket (#8352) #8362

Merged

ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jul 4, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

96d0fc4

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 4, 2024

resource_control: allow configuration of the maximum retry time for the local bucket (#8352) #8364

Merged

nolouch added a commit to nolouch/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

ec321b4

close tikv#8349 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: nolouch <nolouch@gmail.com>

nolouch added a commit to nolouch/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

04d0940

close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com>

nolouch added a commit to nolouch/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

378d77b

close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com>

nolouch added a commit to nolouch/pd that referenced this pull request Jul 4, 2024

This is an automated cherry-pick of tikv#8352

9624bd5

close tikv#8349 Signed-off-by: nolouch <nolouch@gmail.com> Signed-off-by: Shuning Chen <nolouch@ShuningdeMacBook-Pro.local>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource_control: allow configuration of the maximum retry time for the local bucket #8352

resource_control: allow configuration of the maximum retry time for the local bucket #8352

nolouch commented Jul 2, 2024 •

edited

Loading

JmPotato Jul 2, 2024

nolouch Jul 2, 2024 •

edited

Loading

JmPotato left a comment

HuSharp left a comment

nolouch commented Jul 3, 2024

ti-chi-bot bot commented Jul 3, 2024

ti-chi-bot bot commented Jul 3, 2024

ti-chi-bot commented Jul 4, 2024

ti-chi-bot commented Jul 4, 2024

nolouch commented Jul 4, 2024

ti-chi-bot commented Jul 4, 2024

ti-chi-bot commented Jul 4, 2024

resource_control: allow configuration of the maximum retry time for the local bucket #8352

resource_control: allow configuration of the maximum retry time for the local bucket #8352

Conversation

nolouch commented Jul 2, 2024 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

JmPotato Jul 2, 2024

Choose a reason for hiding this comment

nolouch Jul 2, 2024 • edited Loading

Choose a reason for hiding this comment

JmPotato left a comment

Choose a reason for hiding this comment

HuSharp left a comment

Choose a reason for hiding this comment

nolouch commented Jul 3, 2024

ti-chi-bot bot commented Jul 3, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Jul 3, 2024

ti-chi-bot commented Jul 4, 2024

ti-chi-bot commented Jul 4, 2024

nolouch commented Jul 4, 2024

ti-chi-bot commented Jul 4, 2024

ti-chi-bot commented Jul 4, 2024

nolouch commented Jul 2, 2024 •

edited

Loading

nolouch Jul 2, 2024 •

edited

Loading