Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: merge waiting list and suspect regions #8377

Merged
merged 4 commits into from
Jul 12, 2024
Merged

*: merge waiting list and suspect regions #8377

merged 4 commits into from
Jul 12, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 8, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8378

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@rleungx
merge waiting list and suspect regions
496c956 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.20%. Comparing base (86f8030) to head (9ed41bc).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8377      +/-   ##
==========================================
- Coverage   77.31%   77.20%   -0.11%     
==========================================
  Files         470      470              
  Lines       61681    61668      -13     
==========================================
- Hits        47686    47610      -76     
- Misses      10405    10467      +62     
- Partials     3590     3591       +1
Flag Coverage Δ
unittests 77.20% <92.85%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024
lhy1024 reviewed Jul 9, 2024
View reviewed changes
pkg/schedule/checker/checker_controller.go
return c.regionWaitingList.Elems()
// GetPendingProcessedRegions returns the pending processed regions in the cache.
func (c *Controller) GetPendingProcessedRegions() []uint64 {
pendingRegions := make([]uint64, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why copy it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elems() returns []*Item

pkg/schedule/coordinator.go Outdated
for _, id := range c.checkers.GetSuspectRegions() {
func (c *Coordinator) checkPendingProcessedRegions() {
ids := c.checkers.GetPendingProcessedRegions()
waitingListGauge.Set(float64(len(ids)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be renamed?

@rleungx
address the comment
9ed41bc 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved and removed do-not-merge/needs-linked-issue labels Jul 9, 2024
@rleungx rleungx requested review from nolouch and HuSharp July 12, 2024 05:43
HuSharp
HuSharp reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

server/cluster/scheduling_controller.go Outdated Show resolved Hide resolved
@rleungx
fix
17bd462 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 03:37:53.044447203 +0000 UTC m=+328770.279681307: ☑️ agreed by lhy1024.
  • 2024-07-12 07:08:59.570754896 +0000 UTC m=+600636.805989006: ☑️ agreed by HuSharp.

@rleungx
Copy link
Member Author

rleungx commented Jul 12, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2024

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 0378785 into tikv:master Jul 12, 2024
21 checks passed
@rleungx rleungx deleted the pending-processed branch July 12, 2024 07:22
@apollodafoni apollodafoni mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @lhy1024 @HuSharp