Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show approximate_kv_size in pd-ctl #8403

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented Jul 16, 2024

What problem does this PR solve?

Issue Number: Close #8412

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: zeminzhou <zhouzemin@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (0b5ed0f) to head (a455951).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8403      +/-   ##
==========================================
+ Coverage   77.21%   77.32%   +0.11%     
==========================================
  Files         471      471              
  Lines       61806    61835      +29     
==========================================
+ Hits        47723    47815      +92     
+ Misses      10491    10420      -71     
- Partials     3592     3600       +8     
Flag Coverage Δ
unittests 77.32% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-17 05:06:34.463726774 +0000 UTC m=+416816.454668244: ☑️ agreed by nolouch.
  • 2024-07-17 05:49:46.459204204 +0000 UTC m=+419408.450145675: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 1a20c85 into tikv:master Jul 17, 2024
25 checks passed
@zeminzhou zeminzhou deleted the show-approximate-kv-size branch July 17, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show ApproximateKvSize in pd-ctl
3 participants