Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Merge the two tsoStream types to reuse the same error handling and metrics reporting code #8433

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Issue Number: Ref #8432

What is changed and how does it work?

client: Merge the two tsoStream types to reuse the same error handling and metrics reporting code

This commit merges the two `xxxTSOStream` types so that the error handling and metrics reporting logic for PD server deployment and TSO service deployment can be reused.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (5d77447) to head (2c009ae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8433      +/-   ##
==========================================
+ Coverage   77.32%   77.36%   +0.03%     
==========================================
  Files         472      472              
  Lines       61802    61798       -4     
==========================================
+ Hits        47789    47808      +19     
+ Misses      10434    10426       -8     
+ Partials     3579     3564      -15     
Flag Coverage Δ
unittests 77.36% <94.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta MyonKeminta marked this pull request as ready for review July 25, 2024 09:47
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 25, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-25 11:57:16.563099372 +0000 UTC m=+1132658.554040843: ☑️ agreed by JmPotato.
  • 2024-07-29 08:03:26.22879128 +0000 UTC m=+170122.508839347: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 9af28fc into tikv:master Jul 29, 2024
25 checks passed
@MyonKeminta MyonKeminta deleted the m/merge-tso-stream-types branch July 29, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants