Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add some comments to exported function, part of enable revive.exported #8459

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jul 30, 2024

What problem does this PR solve?

Issue Number: Ref #8458, #8440 (comment)

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: okJiang <819421878@qq.com>
Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jul 30, 2024
@okJiang okJiang marked this pull request as ready for review July 30, 2024 10:12
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 30, 2024
Signed-off-by: okJiang <819421878@qq.com>
.golangci.yml Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (9af28fc) to head (da29bf9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8459      +/-   ##
==========================================
- Coverage   77.48%   77.46%   -0.03%     
==========================================
  Files         472      472              
  Lines       61798    61796       -2     
==========================================
- Hits        47887    47868      -19     
- Misses      10341    10360      +19     
+ Partials     3570     3568       -2     
Flag Coverage Δ
unittests 77.46% <90.80%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 02:53:38.786772146 +0000 UTC m=+324335.066820213: ☑️ agreed by HuSharp.
  • 2024-07-31 06:33:05.967753119 +0000 UTC m=+337502.247801188: ☑️ agreed by rleungx.

Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

@okJiang: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 84f90f4 into tikv:master Jul 31, 2024
25 checks passed
@okJiang okJiang deleted the enable-exported branch July 31, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants