Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: create allocator no matter what mode #8473

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 31, 2024

What problem does this PR solve?

Issue Number: ref #8477

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (1335ff9) to head (6acdb0e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8473      +/-   ##
==========================================
- Coverage   77.33%   77.31%   -0.02%     
==========================================
  Files         472      472              
  Lines       61739    61738       -1     
==========================================
- Hits        47744    47731      -13     
- Misses      10422    10434      +12     
  Partials     3573     3573              
Flag Coverage Δ
unittests 77.31% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-05 06:07:48.242148878 +0000 UTC m=+245798.109247958: ☑️ agreed by nolouch.
  • 2024-08-05 06:08:28.372927183 +0000 UTC m=+245838.240026270: ☑️ agreed by JmPotato.

Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit f758f8e into tikv:master Aug 5, 2024
23 of 25 checks passed
@rleungx rleungx deleted the allocator branch August 6, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants