Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: fix the URI of GetRegionLabelRulesByIDs #8490

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 5, 2024

What problem does this PR solve?

Issue Number: close #8491, ref pingcap/tidb#55188.

What is changed and how does it work?

Fix the URI of `GetRegionLabelRulesByIDs` to correct the call.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Aug 5, 2024
@JmPotato JmPotato added the component/client Client logic. label Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 5, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Aug 5, 2024

/test pull-integration-realcluster-test

Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused lint doesn't work 🤔 Let me do some research

Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-05 08:59:49.170275351 +0000 UTC m=+256119.037374440: ☑️ agreed by rleungx.
  • 2024-08-05 09:16:19.425253008 +0000 UTC m=+257109.292352094: ☑️ agreed by okJiang.

@JmPotato
Copy link
Member Author

JmPotato commented Aug 5, 2024

/test build

@JmPotato JmPotato added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 838ee79 into tikv:master Aug 5, 2024
22 checks passed
@JmPotato JmPotato deleted the fix_GetRegionLabelRulesByIDs branch August 5, 2024 09:26
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8493.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 5, 2024
close tikv#8491, ref pingcap/tidb#55188

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 5, 2024
close #8491, ref pingcap/tidb#55188

Fix the URI of `GetRegionLabelRulesByIDs` to correct the call.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetRegionLabelRulesByIDs incorrectly returned all the region label rules
4 participants