Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms: make TestBootstrapDefaultKeyspaceGroup stable #8510

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 9, 2024

What problem does this PR solve?

Issue Number: Close #8395

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 requested review from rleungx and HuSharp August 9, 2024 09:01
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.48%. Comparing base (7741924) to head (76fab87).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8510      +/-   ##
==========================================
+ Coverage   77.40%   77.48%   +0.07%     
==========================================
  Files         472      472              
  Lines       61800    61829      +29     
==========================================
+ Hits        47838    47907      +69     
+ Misses      10395    10347      -48     
- Partials     3567     3575       +8     
Flag Coverage Δ
unittests 77.48% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 9, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-09 09:27:04.014860797 +0000 UTC m=+603353.881959877: ☑️ agreed by HuSharp.
  • 2024-08-09 10:04:15.067955026 +0000 UTC m=+605584.935054114: ☑️ agreed by nolouch.

Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 9, 2024

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit 6783814 into tikv:master Aug 9, 2024
21 checks passed
@lhy1024 lhy1024 deleted the fix-test23 branch August 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestBootstrapDefaultKeyspaceGroup is unstable
3 participants