Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: remove old scheduler name #8516

Merged
merged 13 commits into from
Aug 21, 2024
Merged

scheduler: remove old scheduler name #8516

merged 13 commits into from
Aug 21, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Aug 12, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #8379

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (9c14c63) to head (ff024f3).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8516      +/-   ##
==========================================
+ Coverage   77.56%   77.57%   +0.01%     
==========================================
  Files         474      474              
  Lines       61859    61864       +5     
==========================================
+ Hits        47979    47993      +14     
+ Misses      10350    10342       -8     
+ Partials     3530     3529       -1
Flag Coverage Δ
unittests 77.57% <83.87%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@okJiang okJiang marked this pull request as ready for review August 13, 2024 04:00
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 13, 2024
okJiang added 3 commits August 14, 2024 12:55
@okJiang
update Diagnostic
233b3b9 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
remove the old scheduler name
7439df5 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
remove more
d7d72e7 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2024
okJiang added 2 commits August 14, 2024 14:50
@okJiang
trigger ci
5283b9e 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
trigger ci
5b33df9 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang okJiang mentioned this pull request Aug 15, 2024
Closed
rleungx
rleungx reviewed Aug 15, 2024
View reviewed changes
pkg/schedule/schedulers/diagnostic_recorder.go Outdated
@@ -23,6 +23,7 @@ import (
sc "github.com/tikv/pd/pkg/schedule/config"
"github.com/tikv/pd/pkg/schedule/operator"
"github.com/tikv/pd/pkg/schedule/plan"
types "github.com/tikv/pd/pkg/schedule/type"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming it to types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

pkg/schedule/schedulers/diagnostic_recorder.go Outdated
}
}
return &DiagnosticResult{
Name: d.schedulerName,
Name: string(d.schedulerType),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between string(d.schedulerType) and d.schedulerType.String()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no difference

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then shall we keep consistent with other places?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

okJiang added 4 commits August 15, 2024 15:35
@okJiang
fix comment
633b8a3 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Merge branch 'master' into name7
4cd85d0
@okJiang
unify usage
62a12b0 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Merge branch 'name7' of github.com:okJiang/pd into name7
41289f7
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 21, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-21 02:51:35.734586983 +0000 UTC m=+320290.869037097: ☑️ agreed by rleungx.
  • 2024-08-21 04:01:26.025634034 +0000 UTC m=+324481.160084155: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit ce1d0e8 into tikv:master Aug 21, 2024
21 checks passed
@okJiang okJiang deleted the name7 branch August 21, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okJiang @niubell @lhy1024 @rleungx