mcs/metastorage: remove the register restful API #8583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Signed-off-by: husharp <ihusharp@gmail.com>
HuSharp
force-pushed
the
remove_metastorage_register
branch
from
0b4d948 to
6f8b771
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8583 +/- ##
=======================================
Coverage 77.59% 77.60%
=======================================
Files 474 474
Lines 61883 61884 +1
=======================================
+ Hits 48019 48024 +5
+ Misses 10334 10331 -3
+ Partials 3530 3529 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
cc @okJiang |
HuSharp
commented
Aug 30, 2024
| @@ -266,7 +266,6 @@ func (d *Driver) RegionsHeartbeat(ctx context.Context) { | |||
| healthyNodes[n.Store.GetId()] = true | |||
| } | |||
| } | |||
| report := 0 | |||
rleungx
approved these changes
Aug 30, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
lhy1024
approved these changes
Sep 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After the #8317 merge, we will now have an error log error log
Since the meta storage doesn't provide restful API right now, we can remove the register.
Issue Number: Ref #5836
What is changed and how does it work?
Check List
Tests
Release note