Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: transitioning action version from node 16 to node 20 (#8071) #8631

Merged

Conversation

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 14, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 02:44:15.810346133 +0000 UTC m=+669925.550770072: ☑️ agreed by rleungx.
  • 2024-09-14 03:00:59.39847716 +0000 UTC m=+670929.138901101: ☑️ agreed by nolouch.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.67%. Comparing base (f3dd0b6) to head (3b947e5).
Report is 2 commits behind head on release-8.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.1    #8631      +/-   ##
===============================================
- Coverage        73.77%   73.67%   -0.10%     
===============================================
  Files              437      437              
  Lines            48749    48751       +2     
===============================================
- Hits             35964    35919      -45     
- Misses            9729     9766      +37     
- Partials          3056     3066      +10     
Flag Coverage Δ
unittests 73.67% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx removed type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit c14a833 into tikv:release-8.1 Sep 14, 2024
25 of 26 checks passed
@HuSharp HuSharp deleted the cherry-pick-8071-to-release-8.1 branch September 25, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants