Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: support changing service-middleware config through pd-ctl #8645

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 23, 2024

What problem does this PR solve?

Issue Number: Close #4373, ref #5739, close #8691

What is changed and how does it work?

show

config show service-middleware

set

config set service-middleware audit enable-audit false
config set service-middleware rate-limit GetRegion qps 100
config set service-middleware grpc-rate-limit GetRegion qps 100
config set service-middleware rate-limit GetRegion concurrency 10
config set service-middleware grpc-rate-limit GetRegion concurrency 10

detele

config set service-middleware rate-limit GetRegion qps 0
config set service-middleware grpc-rate-limit GetRegion qps 0
config set service-middleware rate-limit GetRegion concurrency 0
config set service-middleware grpc-rate-limit GetRegion concurrency 0

This PR supports using pd-ctl to manage the service middleware config.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (642f0e9) to head (f30b042).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8645      +/-   ##
==========================================
+ Coverage   77.50%   77.57%   +0.06%     
==========================================
  Files         474      474              
  Lines       62311    62361      +50     
==========================================
+ Hits        48297    48377      +80     
+ Misses      10448    10417      -31     
- Partials     3566     3567       +1     
Flag Coverage Δ
unittests 77.57% <88.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 23, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 12:35:13.460249804 +0000 UTC m=+1482983.200673742: ☑️ agreed by lhy1024.
  • 2024-09-26 02:39:11.050612668 +0000 UTC m=+1706420.791036621: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 76dc560 into tikv:master Sep 26, 2024
25 checks passed
@rleungx rleungx deleted the config-service-middleware branch November 7, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve usability of the gRPC rate limiter Provide PD self-protection mechanism
3 participants