*: unify the receiver naming style #8677
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
ti-chi-bot
bot
added
needs-1-more-lgtm
| @@ -36,13 +36,13 @@ func NewLearnerChecker(cluster sche.CheckerCluster) *LearnerChecker { | |||
| } | |||
|
|
|||
| // Check verifies a region's role, creating an Operator if need. | |||
| func (l *LearnerChecker) Check(region *core.RegionInfo) *operator.Operator { | |||
| if l.IsPaused() { | |||
| func (c *LearnerChecker) Check(region *core.RegionInfo) *operator.Operator { | |||
There was a problem hiding this comment.
but commit message is reduce rand NewSource
There was a problem hiding this comment.
need to merge #8675 first
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8677 +/- ##
==========================================
- Coverage 77.57% 77.57% -0.01%
==========================================
Files 474 474
Lines 62359 62359
==========================================
- Hits 48377 48375 -2
- Misses 10425 10427 +2
Partials 3557 3557
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot
bot
added
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: ref #8379.
What is changed and how does it work?
Checkers use
cand schedulers uses, which is easier to do some replacement.Check List
Tests
Release note