test: make TestLabelerRuleTTL stable #8723
Conversation
Signed-off-by: okJiang <819421878@qq.com>
ti-chi-bot
bot
added
release-note-none
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8723 +/- ##
==========================================
- Coverage 70.03% 70.00% -0.03%
==========================================
Files 517 517
Lines 79947 79947
==========================================
- Hits 55989 55967 -22
- Misses 20382 20413 +31
+ Partials 3576 3567 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -341,7 +341,7 @@ func TestKeyRange(t *testing.T) { | |||
| func TestLabelerRuleTTL(t *testing.T) { | |||
| re := require.New(t) | |||
| store := endpoint.NewStorageEndpoint(kv.NewMemoryKV(), nil) | |||
| labeler, err := NewRegionLabeler(context.Background(), store, time.Millisecond*10) | |||
| labeler, err := NewRegionLabeler(context.Background(), store, time.Minute) | |||
There was a problem hiding this comment.
This test case don't need to test GC.
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@okJiang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Close #8687
What is changed and how does it work?
see #8687 (comment)
Check List
Tests
Release note