-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support configuring tso switch #8755
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8755 +/- ##
==========================================
- Coverage 75.58% 75.57% -0.01%
==========================================
Files 461 461
Lines 72275 72285 +10
==========================================
+ Hits 54627 54631 +4
- Misses 14145 14149 +4
- Partials 3503 3505 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
tsoCluster.WaitForDefaultPrimaryServing(re) | ||
|
||
// Wait for TSO server to start and PD to detect it | ||
time.Sleep(300 * time.Millisecond) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make it a Eventually
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
// Verify PD is not providing TSO service | ||
err = checkTSOMonotonic(ctx, pdClient, &globalLastTS, 10) | ||
re.NoError(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How could this guarantee that the PD is not providing TSO service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the allocator now
/hold I set config to true temporarily for the test. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/retest |
/hold cancel |
/retest |
1 similar comment
/retest |
@niubell PTAL |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024, niubell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #8477.
What is changed and how does it work?
Check List
Tests
Release note