Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove api mode #8780

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

*: remove api mode #8780

wants to merge 6 commits into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 6, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8477.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rleungx and additionally assign yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (5d62787) to head (6163af7).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8780      +/-   ##
==========================================
- Coverage   76.25%   75.99%   -0.26%     
==========================================
  Files         461      461              
  Lines       70395    70384      -11     
==========================================
- Hits        53677    53488     -189     
- Misses      13372    13562     +190     
+ Partials     3346     3334      -12
Flag Coverage Δ
unittests 75.99% <84.74%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx marked this pull request as ready for review November 29, 2024 09:33
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
okJiang
okJiang reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test results?

okJiang
okJiang reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description about these changes.

server/server.go Outdated
if err := s.member.CampaignLeader(s.ctx, s.cfg.LeaderLease); err != nil {
if err.Error() == errs.ErrEtcdTxnConflict.Error() {
log.Info(fmt.Sprintf("campaign %s leader meets error due to txn conflict, another PD/API server may campaign successfully", s.mode),
log.Info("campaign %PD leader meets error due to txn conflict, another PD/API server may campaign successfully",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Info("campaign %PD leader meets error due to txn conflict, another PD/API server may campaign successfully",
log.Info("campaign PD leader meets error due to txn conflict, another PD/API server may campaign successfully",

@rleungx
remove api mode
2a3369e 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
replace more
4b967a6 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
fix
5adc167 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
fix tests
11fbaa4 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
fix tests
dddb935 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
fix
6163af7 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rleungx @okJiang