Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: avoid unexpect scheduling job start #8794

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 8, 2024

What problem does this PR solve?

Issue Number: Ref #8781 ref #8477

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (c9e532c) to head (80c98e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8794      +/-   ##
==========================================
+ Coverage   75.59%   75.61%   +0.01%     
==========================================
  Files         461      461              
  Lines       72304    72310       +6     
==========================================
+ Hits        54660    54676      +16     
+ Misses      14144    14132      -12     
- Partials     3500     3502       +2     
Flag Coverage Δ
unittests 75.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 8, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 06:39:54.196772892 +0000 UTC m=+1195907.035928436: ☑️ agreed by rleungx.
  • 2024-11-08 06:42:11.928199981 +0000 UTC m=+1196044.767355512: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 49307e2 into tikv:master Nov 8, 2024
26 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #8796.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 8, 2024
ref #8781

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants