Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: independent the client option #8813

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Independent the client option to reduce the number of files under the client root directory.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added the component/client Client logic. label Nov 14, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 14, 2024
@JmPotato
Copy link
Member Author

/cc @rleungx @okJiang

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 14, 2024
@ti-chi-bot ti-chi-bot bot requested a review from rleungx November 14, 2024 07:38
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: okJiang.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rleungx @okJiang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 14, 2024
@okJiang
Copy link
Member

okJiang commented Nov 14, 2024

/retest

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 78.31325% with 36 lines in your changes missing coverage. Please review.

Project coverage is 75.22%. Comparing base (40ae26c) to head (6926853).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8813   +/-   ##
=======================================
  Coverage   75.21%   75.22%           
=======================================
  Files         459      459           
  Lines       71843    71843           
=======================================
+ Hits        54035    54042    +7     
- Misses      14351    14352    +1     
+ Partials     3457     3449    -8     
Flag Coverage Δ
unittests 75.22% <78.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package pd
package opt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it have a compatibility issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when upgrading the downstream components, manual modification of the relevant code is required.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 08:26:53.335116665 +0000 UTC m=+517575.525985656: ☑️ agreed by okJiang.
  • 2024-11-14 09:21:49.820682881 +0000 UTC m=+520872.011551875: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 71745a1 into tikv:master Nov 14, 2024
26 checks passed
@JmPotato JmPotato deleted the client_option branch November 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants