Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: split the meta storage client #8822

Merged
merged 2 commits into from
Nov 19, 2024
Merged

client: split the meta storage client #8822

merged 2 commits into from
Nov 19, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Split the meta storage client from the client definitions.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato
Split the meta storage client
892b23a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added the component/client Client logic. label Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 18, 2024
@JmPotato
Copy link
Member Author

/cc @okJiang @rleungx @lhy1024

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2024
@ti-chi-bot ti-chi-bot bot requested a review from lhy1024 November 18, 2024 09:25
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: okJiang.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @okJiang @rleungx @lhy1024

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested a review from rleungx November 18, 2024 09:25
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (40fe83e) to head (dac21a6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8822      +/-   ##
==========================================
- Coverage   75.26%   75.23%   -0.04%     
==========================================
  Files         456      456              
  Lines       71608    71608              
==========================================
- Hits        53898    53875      -23     
- Misses      14281    14305      +24     
+ Partials     3429     3428       -1
Flag Coverage Δ
unittests 75.23% <78.94%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

rleungx
rleungx reviewed Nov 19, 2024
View reviewed changes
client/clients/metastorage/client.go
@@ -0,0 +1,32 @@
// Copyright 2024 TiKV Project Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need clients layer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later I will move the TSO client into this layer too.

client/resource_group/controller/controller.go Outdated Show resolved Hide resolved
@JmPotato
Reuse the meta storage client interface
dac21a6 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from rleungx November 19, 2024 05:46
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 02:30:20.905821249 +0000 UTC m=+928183.096690241: ☑️ agreed by lhy1024.
  • 2024-11-19 06:33:18.263403875 +0000 UTC m=+942760.454272877: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 36cc3f4 into tikv:master Nov 19, 2024
25 checks passed
@JmPotato JmPotato deleted the meta_storage branch November 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @lhy1024 @rleungx