client: separate the metrics package #8833
Conversation
ti-chi-bot
bot
added
release-note-none
JmPotato
changed the title
JmPotato
changed the title
ti-chi-bot
bot
added
the
size/XXL
|
@JmPotato: GitHub didn't allow me to request PR reviews from the following users: okJiang. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. |
|
/cc @okJiang |
|
@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: okJiang. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| func initCmdDurations() { | ||
| // WithLabelValues is a heavy operation, define variable to avoid call it every time. | ||
| CmdDurationTSOWait = cmdDuration.WithLabelValues("wait") |
There was a problem hiding this comment.
We can init them in L150-L199 directly
There was a problem hiding this comment.
It is by design that we have a function to do this so we can call InitAndRegisterMetrics to reinitialize them with a client option.
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
independent_metrics
branch
from
639690c to
c6931e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8833 +/- ##
==========================================
+ Coverage 75.24% 75.31% +0.07%
==========================================
Files 458 458
Lines 71300 71300
==========================================
+ Hits 53650 53700 +50
+ Misses 14236 14197 -39
+ Partials 3414 3403 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What problem does this PR solve?
Issue Number: ref #8690.
What is changed and how does it work?
Check List
Tests
Release note