Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use ResourceExhausted for the rate limit error #8853

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 26, 2024

What problem does this PR solve?

Issue Number: ref #5739

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx changed the title server: use ResourceExhausted server: use ResourceExhausted for rate limit error Nov 26, 2024
@rleungx rleungx changed the title server: use ResourceExhausted for rate limit error server: use ResourceExhausted for the rate limit error Nov 26, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 2.56410% with 38 lines in your changes missing coverage. Please review.

Project coverage is 75.77%. Comparing base (21a04cb) to head (3bcbfde).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8853      +/-   ##
==========================================
+ Coverage   75.74%   75.77%   +0.03%     
==========================================
  Files         460      460              
  Lines       70693    70637      -56     
==========================================
- Hits        53547    53527      -20     
+ Misses      13761    13716      -45     
- Partials     3385     3394       +9     
Flag Coverage Δ
unittests 75.77% <2.56%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from okJiang and lhy1024 November 26, 2024 06:44
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 26, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 07:01:52.468559572 +0000 UTC m=+533500.088214080: ☑️ agreed by lhy1024.
  • 2024-11-26 07:11:33.9329642 +0000 UTC m=+534081.552618715: ☑️ agreed by okJiang.

@okJiang
Copy link
Member

okJiang commented Nov 26, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit f91605a into tikv:master Nov 26, 2024
23 of 25 checks passed
@rleungx rleungx deleted the err branch November 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants