resource control: fix unsafe usage of timer.Reset #8877

lhy1024 · 2024-12-06T06:12:45Z

What problem does this PR solve?

Issue Number: Close #8876

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

codecov · 2024-12-06T06:19:35Z

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (da0000a) to head (384f53d).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8877      +/-   ##
==========================================
+ Coverage   75.86%   76.15%   +0.28%     
==========================================
  Files         460      459       -1     
  Lines       70637    70258     -379     
==========================================
- Hits        53591    53505      -86     
+ Misses      13673    13392     -281     
+ Partials     3373     3361      -12

Flag	Coverage Δ
unittests	`76.15% <10.00%> (+0.28%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

client/resource_group/controller/controller.go

Signed-off-by: lhy1024 <admin@liudos.us>

client/utils/utils.go

Signed-off-by: lhy1024 <admin@liudos.us>

client/timerutils/utils.go

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2024-12-11T08:49:54Z

@lhy1024: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to adding label named lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-12-11T08:51:08Z

@rleungx: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to adding label named lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

rleungx · 2024-12-11T08:52:38Z

/lgtm

ti-chi-bot · 2024-12-11T08:52:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JmPotato,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-11T08:52:44Z

[LGTM Timeline notifier]

Timeline:

2024-12-09 08:47:33.913744459 +0000 UTC m=+255444.002547002: ☑️ agreed by rleungx.
2024-12-11 06:27:10.948361077 +0000 UTC m=+419821.037163619: ☑️ agreed by JmPotato.
2024-12-11 06:28:10.705366166 +0000 UTC m=+419880.794168709: ✖️🔁 reset by JmPotato.
2024-12-11 08:41:43.908436804 +0000 UTC m=+427893.997239344: ☑️ agreed by JmPotato.
2024-12-11 08:52:43.993003832 +0000 UTC m=+428554.081806375: ☑️ agreed by rleungx.

lhy1024 · 2024-12-11T09:02:39Z

/cherry-pick-release-7.5

lhy1024 · 2024-12-11T09:02:44Z

/cherry-pick-release-7.1

lhy1024 · 2024-12-11T09:29:52Z

/cherry-pick release-7.5

lhy1024 · 2024-12-11T09:29:56Z

/cherry-pick release-7.1

ti-chi-bot · 2024-12-11T09:30:29Z

@lhy1024: new pull request created to branch release-7.5: #8900.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close tikv#8876 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-12-11T09:30:34Z

@lhy1024: new pull request created to branch release-7.1: #8901.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #8876 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2024

rleungx reviewed Dec 6, 2024

View reviewed changes

client/resource_group/controller/controller.go Outdated Show resolved Hide resolved

JmPotato reviewed Dec 9, 2024

View reviewed changes

client/resource_group/controller/controller.go Outdated Show resolved Hide resolved

lhy1024 changed the base branch from master to release-8.1 December 9, 2024 07:37

ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2024

lhy1024 added 2 commits December 9, 2024 15:37

resource control: fix unsafe usage of timer.Reset

b0514ff

Signed-off-by: lhy1024 <admin@liudos.us>

address comments

b8093f4

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the fix-timer branch from 384f53d to b8093f4 Compare December 9, 2024 07:43

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2024

fix lint

72fd514

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx reviewed Dec 9, 2024

View reviewed changes

client/utils/utils.go Outdated Show resolved Hide resolved

address comments

1ae0cf3

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx reviewed Dec 9, 2024

View reviewed changes

client/timerutils/utils.go Outdated Show resolved Hide resolved

rleungx reviewed Dec 9, 2024

View reviewed changes

client/timerutils/utils.go Outdated Show resolved Hide resolved

lhy1024 added 2 commits December 9, 2024 16:32

fix license

03a42e9

Signed-off-by: lhy1024 <admin@liudos.us>

fix

b6715bc

Signed-off-by: lhy1024 <admin@liudos.us>

rleungx approved these changes Dec 9, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 9, 2024

lhy1024 removed the do-not-merge/needs-triage-completed label Dec 9, 2024

JmPotato approved these changes Dec 11, 2024

View reviewed changes

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2024

lhy1024 requested a review from JmPotato December 11, 2024 06:50

fix lint

cbfb74d

Signed-off-by: lhy1024 <admin@liudos.us>

JmPotato approved these changes Dec 11, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2024

lhy1024 added the lgtm label Dec 11, 2024

ti-chi-bot bot removed the lgtm label Dec 11, 2024

rleungx added the lgtm label Dec 11, 2024

ti-chi-bot bot removed the lgtm label Dec 11, 2024

ti-chi-bot bot added the lgtm label Dec 11, 2024

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2024

ti-chi-bot bot merged commit 86d4ad0 into tikv:release-8.1 Dec 11, 2024
21 checks passed

lhy1024 deleted the fix-timer branch December 11, 2024 09:02

ti-chi-bot mentioned this pull request Dec 11, 2024

resource control: fix unsafe usage of timer.Reset (#8877) #8900

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2024

This is an automated cherry-pick of tikv#8877

06c5c42

close tikv#8876 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Dec 11, 2024

resource control: fix unsafe usage of timer.Reset (#8877) #8901

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024

resource control: fix unsafe usage of timer.Reset (#8877) (#8900)

21a31ab

close #8876 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot pushed a commit that referenced this pull request Dec 20, 2024

resource control: fix unsafe usage of timer.Reset (#8877) (#8901)

a5ca5e7

close #8876 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource control: fix unsafe usage of timer.Reset #8877

resource control: fix unsafe usage of timer.Reset #8877

lhy1024 commented Dec 6, 2024

codecov bot commented Dec 6, 2024 •

edited

Loading

ti-chi-bot bot commented Dec 11, 2024

ti-chi-bot bot commented Dec 11, 2024

rleungx commented Dec 11, 2024

ti-chi-bot bot commented Dec 11, 2024

ti-chi-bot bot commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

ti-chi-bot commented Dec 11, 2024

ti-chi-bot commented Dec 11, 2024

resource control: fix unsafe usage of timer.Reset #8877

resource control: fix unsafe usage of timer.Reset #8877

Conversation

lhy1024 commented Dec 6, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

codecov bot commented Dec 6, 2024 • edited Loading

Codecov Report

ti-chi-bot bot commented Dec 11, 2024

ti-chi-bot bot commented Dec 11, 2024

rleungx commented Dec 11, 2024

ti-chi-bot bot commented Dec 11, 2024

ti-chi-bot bot commented Dec 11, 2024

[LGTM Timeline notifier]

lhy1024 commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

lhy1024 commented Dec 11, 2024

ti-chi-bot commented Dec 11, 2024

ti-chi-bot commented Dec 11, 2024

codecov bot commented Dec 6, 2024 •

edited

Loading