update the prost generated file and remove malloc_free #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Closed
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
changed the title
Closed
sticnarf
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
LGTM
It seems that even when the minor version of prost-build doesn't change, it will also generate different files
If the updates of the generated file matter, a PR like this should work. I don't think different patch versions of prost-build will generate completely imcompatible code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
It seems that even when the minor version of prost-build doesn't change, it will also generate different files 🤔 . Maybe we'll need to lock the patch version of
prost-build? (I don't know whether it will break users' choices).For removing malloc free test:
I record an issue #189. I haven't thought about some good ways to solve this problem, so I removed them temporarily.
I have to merge these two PRs into one, or I cannot get any one of them merged 😢 .