Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct required-features for profile_proto example #206

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

Rustin170506
Copy link
Member

Before:

pprof-rs git:(master) ✗ cargo run --example profile_proto --features="protobuf"                            
    Blocking waiting for file lock on build directory
   Compiling pprof v0.11.1 (/Users/hi-rustin/vsc/pprof-rs)
error[E0432]: unresolved import `pprof::protos`
 --> examples/profile_proto.rs:3:12
  |
3 | use pprof::protos::Message;
  |            ^^^^^^ could not find `protos` in `pprof`

error[E0599]: no method named `pprof` found for struct `pprof::Report` in the current scope
   --> examples/profile_proto.rs:104:30
    |
104 |         let profile = report.pprof().unwrap();
    |                              ^^^^^ method not found in `pprof::Report`

Some errors have detailed explanations: E0432, E0599.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `pprof` due to 2 previous errors

After:

pprof-rs git:(master) ✗ cargo run --example profile_proto                                                  
error: target `profile_proto` in package `pprof` requires the features: `protobuf`, `prost-codec`
Consider enabling them by passing, e.g., `--features="protobuf prost-codec"

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao YangKeao merged commit e94a1b0 into tikv:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants