Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump protobuf for RUSTSEC-2019-0003 #54

Closed
wants to merge 2 commits into from
Closed

bump protobuf for RUSTSEC-2019-0003 #54

wants to merge 2 commits into from

Conversation

PsiACE
Copy link

@PsiACE PsiACE commented Jun 1, 2021

Just bump protobuf to 2.8, consistent with tikv, avoid RUSTSEC-2019-0003

Signed-off-by: Chojan Shang psiace@outlook.com

PsiACE added 2 commits June 1, 2021 17:26
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
@BusyJay
Copy link
Member

BusyJay commented Sep 13, 2021

Isn't 2 includes "2.8" already?

@PsiACE
Copy link
Author

PsiACE commented Sep 13, 2021

Isn't 2 includes "2.8" already?

But 2 also includes 2.7 and below

@BusyJay
Copy link
Member

BusyJay commented Sep 13, 2021

Yes, so dependents can upgrade to preferred versions at any time. As long as it doesn't depend on affected versions only, there is nothing to be done in a library.

@PsiACE
Copy link
Author

PsiACE commented Sep 13, 2021

But 2 does not guarantee that you will use version 2.8 and above

@BusyJay
Copy link
Member

BusyJay commented Sep 13, 2021

Cargo will guarantee latest version is used when possible. If a Cargo.lock is used, it's binary maintainer's responsibility to update the vulnerable dependencies.

@PsiACE
Copy link
Author

PsiACE commented Sep 13, 2021

Cargo will guarantee latest version is used when possible. If a Cargo.lock is used, it's binary maintainer's responsibility to update the vulnerable dependencies.

ok

@PsiACE PsiACE closed this by deleting the head repository Apr 4, 2024
@kennytm
Copy link

kennytm commented Apr 4, 2024

Cargo will guarantee latest version is used when possible.

Not really, Cargo has the (unstable) features -Z minimal-versions and -Z direct-minimal-versions flags (rust-lang/cargo#5657) which the former allows the resolver to pick 2.0.0 rather than 2.8.x.

Of course, at the end it is still the binary maintainer's (only they can add those 2 flags to affect the generated Cargo.lock) responsibility to pin protobuf to 2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants