Bump nix, rand, and more #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chojan Shang <psiace@outlook.com>
tabokie
approved these changes
Dec 6, 2021
| e => std::io::Error::new(std::io::ErrorKind::Other, format!("{}: {:?}", custom, e)), | ||
| } | ||
| let kind = std::io::Error::from(e).kind(); | ||
| std::io::Error::new(kind, custom) |
There was a problem hiding this comment.
Handle the case where kind == Other?
There was a problem hiding this comment.
In nix 0.23, all error types have been unified to Errno, and it appears that the Other kind no longer needs to be handled
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 96.96% 96.99% +0.02%
==========================================
Files 26 26
Lines 6597 6594 -3
==========================================
- Hits 6397 6396 -1
+ Misses 200 198 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chojan Shang psiace@outlook.com