Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LogBatch::is_empty() #212

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix LogBatch::is_empty() #212

merged 1 commit into from
Apr 12, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Apr 12, 2022

Adding an empty list of entries to log batch should not change the output of is_empty().

Signed-off-by: tabokie xy.tao@outlook.com

Signed-off-by: tabokie <xy.tao@outlook.com>
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #212 (2ee09c3) into master (2fe0c36) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   96.98%   96.96%   -0.02%     
==========================================
  Files          28       28              
  Lines        7687     7704      +17     
==========================================
+ Hits         7455     7470      +15     
- Misses        232      234       +2     
Impacted Files Coverage Δ
src/log_batch.rs 97.34% <100.00%> (+0.05%) ⬆️
src/consistency.rs 91.11% <0.00%> (-2.23%) ⬇️
src/codec.rs 98.34% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe0c36...2ee09c3. Read the comment docs.

@tabokie tabokie merged commit 1e2a947 into tikv:master Apr 12, 2022
@tabokie tabokie deleted the fix-empty-append branch April 12, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant