Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata deletion capability to FileSystem trait #229

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Add metadata deletion capability to FileSystem trait #229

merged 7 commits into from
Jun 23, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jun 22, 2022

User should be allowed to manage file deletion. For example, in TiKV, file encryption key can be deleted once the corresponding file is deleted.

tabokie added 2 commits June 22, 2022 16:18
@tabokie
let file system manage file deletion
a6777cf 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
update changelog
1b8c2ce 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie requested a review from Connor1996 June 22, 2022 08:21
Connor1996
Connor1996 reviewed Jun 22, 2022
View reviewed changes
src/env/obfuscated.rs Outdated Show resolved Hide resolved
@tabokie
address comment and fix test
d0ae112 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie requested a review from Connor1996 June 22, 2022 08:36
@codecov
Copy link

codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #229 (3477adf) into master (b0ad1f7) will decrease coverage by 0.06%.
The diff coverage is 96.31%.

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   97.18%   97.12%   -0.07%     
==========================================
  Files          29       30       +1     
  Lines        9066     9216     +150     
==========================================
+ Hits         8811     8951     +140     
- Misses        255      265      +10
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/file_pipe_log/pipe_builder.rs 95.48% <80.00%> (-1.48%) ⬇️
src/engine.rs 97.50% <99.00%> (+0.11%) ⬆️
src/env/default.rs 92.13% <100.00%> (+0.13%) ⬆️
src/env/mod.rs 100.00% <100.00%> (ø)
src/env/obfuscated.rs 95.38% <100.00%> (+1.63%) ⬆️
src/file_pipe_log/pipe.rs 99.14% <100.00%> (+0.28%) ⬆️
tests/failpoints/test_engine.rs 100.00% <100.00%> (ø)
src/consistency.rs 91.11% <0.00%> (-2.23%) ⬇️
src/log_batch.rs 96.60% <0.00%> (-0.44%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ad1f7...3477adf. Read the comment docs.

Connor1996
Connor1996 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tabokie added 3 commits June 23, 2022 12:57
@tabokie
detect and cleanup stale metadata on startup
b2f8578 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
update changelog
108211e 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
Merge branch 'master' of https://github.com/tikv/raft-engine into del…
a5063e3 
…ete-file

Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie changed the title Add delete to FileSystem trait API Add metadata deletion capability to FileSystem trait Jun 23, 2022
@tabokie
fix issues
3477adf 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie merged commit a950ec5 into tikv:master Jun 23, 2022
@tabokie tabokie deleted the delete-file branch June 23, 2022 06:07
tabokie added a commit to tabokie/raft-engine that referenced this pull request Jun 23, 2022
@tabokie
Add metadata deletion capability to FileSystem trait (tikv#229)
767122e 
* let file system manage file deletion

Signed-off-by: tabokie <xy.tao@outlook.com>

* update changelog

Signed-off-by: tabokie <xy.tao@outlook.com>

* address comment and fix test

Signed-off-by: tabokie <xy.tao@outlook.com>

* detect and cleanup stale metadata on startup

Signed-off-by: tabokie <xy.tao@outlook.com>

* update changelog

Signed-off-by: tabokie <xy.tao@outlook.com>

* fix issues

Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie mentioned this pull request Jun 23, 2022
Merged
tabokie added a commit that referenced this pull request Jun 23, 2022
@tabokie
Add metadata deletion capability to FileSystem trait (#229) (#230)
605d329 
* let file system manage file deletion

Signed-off-by: tabokie <xy.tao@outlook.com>

* update changelog

Signed-off-by: tabokie <xy.tao@outlook.com>

* address comment and fix test

Signed-off-by: tabokie <xy.tao@outlook.com>

* detect and cleanup stale metadata on startup

Signed-off-by: tabokie <xy.tao@outlook.com>

* update changelog

Signed-off-by: tabokie <xy.tao@outlook.com>

* fix issues

Signed-off-by: tabokie <xy.tao@outlook.com>
LykxSassinator added a commit to LykxSassinator/raft-engine that referenced this pull request Jun 23, 2022
@LykxSassinator
Make Recycle log files compatible to the new feature tikv#229.
cf9b77e 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@tabokie tabokie mentioned this pull request Jun 24, 2022
Merged
@ti-srebot ti-srebot mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabokie @Connor1996