Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix append recovery bug #251

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix append recovery bug #251

merged 2 commits into from
Jul 26, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jul 25, 2022

Close #250

Signed-off-by: tabokie xy.tao@outlook.com

Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #251 (0159528) into master (ee024c7) will decrease coverage by 0.01%.
The diff coverage is 98.48%.

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   97.01%   96.99%   -0.02%     
==========================================
  Files          30       30              
  Lines       10447    10491      +44     
==========================================
+ Hits        10135    10176      +41     
- Misses        312      315       +3     
Impacted Files Coverage Δ
tests/failpoints/test_engine.rs 99.80% <ø> (-0.20%) ⬇️
src/memtable.rs 97.50% <98.48%> (+<0.01%) ⬆️
src/consistency.rs 91.11% <0.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee024c7...0159528. Read the comment docs.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie tabokie merged commit 70d27ee into tikv:master Jul 26, 2022
tabokie added a commit to tabokie/raft-engine that referenced this pull request Jul 26, 2022
Close tikv#250

Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie added a commit that referenced this pull request Jul 26, 2022
Close #250

Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overwrite panic during recovery
2 participants