Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the strategy of tolerating tail corruption when Version == V2. #255

Closed
wants to merge 3 commits into from

Conversation

LykxSassinator
Copy link
Contributor

Supplemented bugfix for #249 , to unify the strategy on whether tolerating the tail corruption when version == V2.

Signed-off-by: Lucasliang nkcs_lykx@hotmail.com

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Contributor Author

/cc @tabokie thanks for reviewing.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #255 (6717f8f) into master (c3a6156) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   97.24%   97.22%   -0.02%     
==========================================
  Files          30       30              
  Lines       10951    10989      +38     
==========================================
+ Hits        10649    10684      +35     
- Misses        302      305       +3     
Impacted Files Coverage Δ
src/file_pipe_log/format.rs 98.95% <100.00%> (+0.02%) ⬆️
src/file_pipe_log/log_file.rs 99.58% <100.00%> (+0.02%) ⬆️
src/file_pipe_log/pipe_builder.rs 96.25% <100.00%> (+0.01%) ⬆️
tests/failpoints/test_engine.rs 99.84% <100.00%> (+<0.01%) ⬆️
src/consistency.rs 91.11% <0.00%> (-2.23%) ⬇️
src/env/default.rs 92.39% <0.00%> (-0.55%) ⬇️
src/log_batch.rs 97.57% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a6156...6717f8f. Read the comment docs.

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@tabokie
Copy link
Member

tabokie commented Aug 3, 2022

Closing this, I'll fix it in #244

@tabokie tabokie closed this Aug 3, 2022
@tabokie
Copy link
Member

tabokie commented Aug 3, 2022

Actually, this is not possible anymore with file recycle. Because file_size is already larger than header_size even before the header is written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants