Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve examples in documentation. #118

Merged
merged 4 commits into from
Sep 12, 2018
Merged

Improve examples in documentation. #118

merged 4 commits into from
Sep 12, 2018

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Sep 7, 2018 •
edited
Loading

Adds another tested documentation example.

Part of #70

@Hoverbear Hoverbear added the Enhancement An improvement to existing code. label Sep 7, 2018
@Hoverbear Hoverbear added this to the 0.4.0 milestone Sep 7, 2018
@Hoverbear Hoverbear self-assigned this Sep 7, 2018
@Hoverbear Hoverbear added Documentation Documentation related issues and fixes. and removed Enhancement An improvement to existing code. labels Sep 7, 2018
overvenus
overvenus approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@overvenus
Copy link
Member

I'm curious about why CI reports ok while there are some panicking tests.

@Hoverbear
Copy link
Contributor Author

@overvenus Those are tests that #[should_panic].

breezewish
breezewish approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The supplied documentation is friendly!

@Hoverbear Hoverbear merged commit 13ec5ac into master Sep 12, 2018
@Hoverbear Hoverbear deleted the more-docs-2 branch September 12, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@breezewish breezewish breezewish approved these changes

Assignees

@Hoverbear Hoverbear

Labels
Documentation Documentation related issues and fixes.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @overvenus @breezewish