Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a test case about power cycle. #173

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jan 29, 2019

Without the PR, test case leader_power_cycles_no_compaction fails because conf state is not persisted before power cycle. We need to do this explicitly.

The PR also contains some code format generated by cargo fmt. I have checked the cargo version, seems my toolchain is correct. Seems you forget to format code? If so, let's keep those changes.

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu requested a review from Hoverbear January 29, 2019 07:04
@hicqu
Copy link
Contributor Author

hicqu commented Jan 29, 2019

PTAL @Hoverbear thank you!

Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging PR to other PR.

@Hoverbear Hoverbear merged commit 7b84b24 into tikv:joint-consensus Jan 29, 2019
@hicqu hicqu deleted the joint-consensus-bug-fix branch January 30, 2019 03:14
@Hoverbear Hoverbear added this to the 0.6.0 milestone Feb 11, 2019
@Hoverbear Hoverbear removed this from the 0.6.0 milestone Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants