Update to Rust 2018 #184
Merged
Update to Rust 2018 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
reviewed
Feb 19, 2019
Hoverbear
previously approved these changes
Feb 19, 2019
|
I've updated generate-proto.sh to rerun cargo fix so we don't lose the changes. |
|
@nrc Great, that solves that problem! |
Hoverbear
previously approved these changes
Feb 20, 2019
Merged
brson
previously approved these changes
Feb 21, 2019
|
LGTM |
|
Rebased, reviewed, ready to merge |
|
@nrc Builds are failing at the moment. :( |
The toolchains tested on CI are specified in their own ways, so this is only used for local builds where developers. Its better for developers not to have this file around in case they have their own preferences.
|
@Hoverbear fixed! |
Hoverbear
approved these changes
Feb 22, 2019
|
Forcing merge with LGTMs from me and @brson (there was a rebase) |
Hoverbear
pushed a commit
that referenced
this pull request
Apr 23, 2019
* Regenerate Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Update to Rust 2018 (#184) * Migrate to Rust 2018 * Remove rust-toolchain file The toolchains tested on CI are specified in their own ways, so this is only used for local builds where developers. Its better for developers not to have this file around in case they have their own preferences. (cherry picked from commit addddd2) Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Migration leftovers Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Fix compilation errors under `src` Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Fix most test failings Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Remove some unintentional changes produced by careless merging Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Use tikv/protobuf-build#3 Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Fix warning Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Fix tests Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Bump protobuf-build to 0.4.2 Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Address some warnings (#219) Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Address comments: add `Codec` back, replace protobuf version with 2 Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Address nightly warnings Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Remove the whole `cfg_attr` Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is the update, it is all pretty straightforward. The second commit removes the rust-toolchain file because I think it is a better developer experience not to have it checked in.
@Hoverbear @brson PTAL