Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove ignore codefences for examples #289

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

psinghal20
Copy link
Contributor

Remove code fences to compile and test examples.

Fixes #70, Redo #194

@BusyJay
Copy link
Member

BusyJay commented Sep 18, 2019

Cool, looks good to me generally. Can you update the PR to adapt the latest APIs from master?

Signed-off-by: psinghal20 <psinghal20@gmail.com>
@psinghal20
Copy link
Contributor Author

@BusyJay Done. PTAL

@siddontang
Copy link
Contributor

PTAL @Hoverbear @nrc

@Hoverbear Hoverbear merged commit b36ab40 into tikv:master Sep 25, 2019
@Hoverbear
Copy link
Contributor

Thanks for this contribution, @psinghal20 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tested examples in src/lib.rs Rustdocs
4 participants