raft: port disruptive test #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
BusyJay
reviewed
Mar 19, 2018
tests/cases/test_raft.rs
Outdated
| @@ -2260,6 +2260,154 @@ fn test_non_promotable_voter_which_check_quorum() { | |||
| assert_eq!(nt.peers[&2].leader_id, 1); | |||
| } | |||
|
|
|||
| #[test] | |||
| // test_disruptive_follower tests isolated follower, | |||
There was a problem hiding this comment.
Please use doc comment and put the #[test] attribute below the comments.
tests/cases/test_raft.rs
Outdated
| nt.send(vec![new_message(1, 1, MessageType::MsgPropose, 1)]); | ||
| nt.send(vec![new_message(1, 1, MessageType::MsgPropose, 1)]); | ||
|
|
||
| nt.peers.get_mut(&1).unwrap().pre_vote = true; |
There was a problem hiding this comment.
I think this can be set when the node is created using new_test_raft_with_prevote.
BusyJay
reviewed
Mar 21, 2018
src/raft.rs
Outdated
| @@ -224,7 +224,7 @@ pub struct Raft<T: Storage> { | |||
| heartbeat_elapsed: usize, | |||
|
|
|||
| pub check_quorum: bool, | |||
| pre_vote: bool, | |||
| pub pre_vote: bool, | |||
There was a problem hiding this comment.
Seems it doesn't have to be pub now?
siddontang
previously approved these changes
Mar 21, 2018
BusyJay
approved these changes
Mar 23, 2018
|
Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the port the raft relate part in etcd about #39