Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: Add links to PRs #85

Merged
merged 2 commits into from
Jul 11, 2018
Merged

changelog: Add links to PRs #85

merged 2 commits into from
Jul 11, 2018

Conversation

Hoverbear
Copy link
Contributor

Add links to the changelog so it's easier to see what happened.

@Hoverbear Hoverbear self-assigned this Jul 5, 2018
@Hoverbear Hoverbear added this to the 0.3.1 milestone Jul 5, 2018
overvenus
overvenus previously approved these changes Jul 6, 2018
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated
- Add more docs and example
- Support configuring election timeout range
- Now supports configuring the election timeout range (https://github.com/pingcap/raft-rs/pull/63).
- Fixed a compiler error (https://github.com/pingcap/raft-rs/pull/64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both this and "Workaround a problem" are parts of "keep compatible with rust-protobuf 2.0", which seems more clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated
- Make raft `Send`
- Add more docs and example
- Support configuring election timeout range
- Now supports configuring the election timeout range (https://github.com/pingcap/raft-rs/pull/63).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why here use supports but later use made, added? different tense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

CHANGELOG.md Outdated
- Port several tests
- Add examples
- Use fxhash
- Deprecated sync-log and add context (https://github.com/pingcap/raft-rs/pull/59)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear merged commit fe94797 into master Jul 11, 2018
@tisonkun tisonkun deleted the changelog-links branch July 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants