Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Extract to own file. #91

Merged
merged 2 commits into from
Aug 1, 2018
Merged

config: Extract to own file. #91

merged 2 commits into from
Aug 1, 2018

Conversation

Hoverbear
Copy link
Contributor

Extract the Config struct to its own file.

Reasoning: Currently the src/raft.rs file is very long, it can be reduced by extracting some unrelated things, like the configuration.

@Hoverbear Hoverbear added the Enhancement An improvement to existing code. label Jul 10, 2018
@Hoverbear Hoverbear self-assigned this Jul 10, 2018
siddontang
siddontang previously approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

BusyJay
BusyJay previously approved these changes Jul 11, 2018
View reviewed changes
@Hoverbear Hoverbear added this to the 0.4.0 milestone Jul 11, 2018
@Hoverbear Hoverbear added Do Not Merge A blocked PR. Please do not merge it. and removed Do Not Merge A blocked PR. Please do not merge it. labels Jul 11, 2018
@Hoverbear Hoverbear dismissed stale reviews from BusyJay and siddontang via b17957d July 13, 2018 17:35
@Hoverbear
Copy link
Contributor Author

I rebased this due to #87. PTAL.

@Hoverbear
Copy link
Contributor Author

Rebased. PTAL.

siddontang
siddontang approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

PTAL @BusyJay

@Hoverbear Hoverbear merged commit 935840b into master Aug 1, 2018
@tisonkun tisonkun deleted the extract-config branch July 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

@siddontang siddontang siddontang approved these changes

Assignees

@Hoverbear Hoverbear

Labels
Enhancement An improvement to existing code.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @siddontang @BusyJay