Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OnFlushCompleted fired before flush result write to MANIFEST (#59… #130

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix OnFlushCompleted fired before flush result write to MANIFEST (#59… #130

merged 1 commit into from
Nov 19, 2019

Commits on Nov 19, 2019

  1. Fix OnFlushCompleted fired before flush result write to MANIFEST (fac… 

    …ebook#5908) (#127)

Summary:
When there are concurrent flush job on the same CF, `OnFlushCompleted` can be called before the flush result being install to LSM. Fixing the issue by passing `FlushJobInfo` through `MemTable`, and the thread who commit the flush result can fetch the `FlushJobInfo` and fire `OnFlushCompleted` on behave of the thread actually writing the SST.

Fix facebook#5892
Pull Request resolved: facebook#5908

Test Plan: Add new test. The test will fail without the fix.

Differential Revision: D17916144

Pulled By: riversand963

fbshipit-source-id: e18df67d9533b5baee52ae3605026cdeb05cbe10
Signed-off-by: Yi Wu <yiwu@pingcap.com>
    yiwu-arbug committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    3af40cf View commit details
    Browse the repository at this point in the history