[PCP-21] Titan GC doesn’t affect online write #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
yiwu-arbug
reviewed
Feb 11, 2020
| "Encounter unexpected blob index. Please open DB with " | ||
| "rocksdb::blob_db::BlobDB instead."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
ok, I didn't realize Titan doesn't support MultiGet (needs to make is_blob a vector of boolean for each key being query).
yiwu-arbug
reviewed
Feb 11, 2020
Connor1996
reviewed
Feb 12, 2020
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
force-pushed
the
green-blob-gc
branch
from
56a3d1b to
704aea1
Compare
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
reviewed
Feb 12, 2020
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
reviewed
Feb 13, 2020
| logger_, statistics_, env_); | ||
| pinnable_val_->PinSelf(); | ||
| if (!merge_status.ok()) { | ||
| state_ = kCorrupt; | ||
| } else if (is_blob_index_ != nullptr) { | ||
| *is_blob_index_ = (type == kTypeBlobIndex); |
There was a problem hiding this comment.
I think state_ is kFound here. kBlobIndex is an abnormal state.
Connor1996
reviewed
Feb 13, 2020
There was a problem hiding this comment.
LGTM overall, but I'm not quite familiar with the implementation to find potential bugs. PTAL again
@yiwu-arbug
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
approved these changes
Feb 14, 2020
|
/test |
Signed-off-by: tabokie <xy.tao@outlook.com>
|
Please fix failed tests |
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
|
Let's send this PR to upstream. |
|
@yiwu-arbug facebook#6447 PTAL |
yiwu-arbug
pushed a commit
that referenced
this pull request
Mar 20, 2020
tikv/tikv#5739 Summary: - support blob index as merge base value - add value type to merge input - support merge operation changes value type (restricted set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tikv/tikv#5739
Summary: