add range for compaction filter context #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
force-pushed
the
compaction-filter-range
branch
2 times, most recently
from
f57abd2
to
3aeca4d
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
force-pushed
the
compaction-filter-range
branch
from
3aeca4d
to
e268eaa
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
|
/merge |
yiwu-arbug
reviewed
Nov 9, 2020
| @@ -56,6 +59,18 @@ class CompactionFilter { | |||
| bool is_manual_compaction; | |||
| // Whether output files are in bottommost level or not. | |||
| bool is_bottommost_level; | |||
|
|
|||
| // The range of the compaction. | |||
| Slice start_key; | |||
There was a problem hiding this comment.
Should these use the V2 struct above?
yiwu-arbug
pushed a commit
to tikv/rust-rocksdb
that referenced
this pull request
Nov 9, 2020
update rocksdb to include tikv/rocksdb#192 for master Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
* add range for compaction filter context Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
May 12, 2022
* add range for compaction filter context Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Feb 21, 2024
* add range for compaction filter context Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Feb 22, 2024
compaction_filter: add bottommost_level into context (tikv#160) Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> add range for compaction filter context (tikv#192) * add range for compaction filter context Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> allow no_io for VersionSet::GetTableProperties (tikv#211) * allow no_io for VersionSet::GetTableProperties Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> expose seqno from compaction filter and iterator (tikv#215) This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> allow to query DB stall status (tikv#226) This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> Fix compatibilty issue with Titan Signed-off-by: v01dstar <yang.zhang@pingcap.com> filter deletion in compaction filter (tikv#344) And delay the buffer initialization of writable file to first actual write. --------- Signed-off-by: tabokie <xy.tao@outlook.com> Adjustments for compaptibilty with 8.10.facebook Signed-off-by: v01dstar <yang.zhang@pingcap.com> Adjust tikv related changes with upstream Signed-off-by: v01dstar <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qupeng qupeng@pingcap.com
This PR adds some information into
CompactionFilter::Context:These fields can be used in
CompactionFilterFactory::create_compaction_filter.