Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pace up limiter before triggering write stall #207

Merged
merged 5 commits into from
Nov 16, 2020

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Nov 6, 2020

Signed-off-by: tabokie xy.tao@outlook.com

Proactively pace up auto-tuned rate limiter when LSM shape (L0-count/pending-bytes) is close to trigger write stall.

Mitigate tikv/tikv#8962

run wide_table sysbench with 512 threads 100 columns
Before:

image

After the patch:

image

Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie tabokie merged commit 355b496 into tikv:6.4.tikv Nov 16, 2020
@tabokie tabokie deleted the fix-limit branch December 23, 2020 03:17
@tabokie tabokie mentioned this pull request May 9, 2022
39 tasks
tabokie added a commit to tabokie/rocksdb that referenced this pull request May 10, 2022
Proactively pace up auto-tuned rate limiter when LSM shape (L0-count/pending-bytes) is close to trigger write stall.

Test plan: sysbench wide_table 512 threads 100 columns

Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie added a commit that referenced this pull request May 11, 2022
Proactively pace up auto-tuned rate limiter when LSM shape (L0-count/pending-bytes) is close to trigger write stall.

Test plan: sysbench wide_table 512 threads 100 columns

Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants