Do not tune down write-amp based rate limit when flush flow decreases #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
reviewed
Aug 11, 2021
Signed-off-by: tabokie <xy.tao@outlook.com>
|
Pin @yiwu-arbug |
yiwu-arbug
reviewed
Aug 18, 2021
| // Only adjust threshold when foreground write (flush) flow increases, | ||
| // because decreasement could also be caused by manual flow control at | ||
| // application level to alleviate background pressure. | ||
| new_bytes_per_sec = std::max( |
There was a problem hiding this comment.
so when foreground flow decreases, we use long term average throughput as new rate limit? just want to understand the logic.
There was a problem hiding this comment.
Yes, and this is consistent with before:
When flush flow is steady, i.e. flush_flow.full() == flush_flow.recent(),
old algorithm yields new_bytes_per_sec = ratio * flush_flow.recent() = compaction_flow.full() / flush_flow.full() * flush_flow.recent() = compaction_flow.full()
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 10, 2022
…tikv#234) Because foreground writes can be proactively restrained when compactions lag behind, added a minor algorithm change that avoids tuning down rate limit when foreground writes (flush flow) decrease. This will not affect the overall performance of `WriteAmpBasedRateLimiter`. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
that referenced
this pull request
May 11, 2022
…#234) Because foreground writes can be proactively restrained when compactions lag behind, added a minor algorithm change that avoids tuning down rate limit when foreground writes (flush flow) decrease. This will not affect the overall performance of `WriteAmpBasedRateLimiter`. Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because foreground writes can be proactively restrained when compactions lag behind, added a minor algorithm change that avoids tuning down rate limit when foreground writes (flush flow) decrease. This will not affect the overall performance of
WriteAmpBasedRateLimiter.