Pick add ldb unsafe_remove_sst_file subcommand #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterlxt
force-pushed
the
xt/pick-unsafe_remove_sst_file
branch
3 times, most recently
from
5add7b6
to
8addbe2
Compare
hunterlxt
force-pushed
the
xt/pick-unsafe_remove_sst_file
branch
from
8addbe2
to
0ee45a7
Compare
Signed-off-by: Xintao <hunterlxt@live.com>
Signed-off-by: Xintao <hunterlxt@live.com>
hunterlxt
force-pushed
the
xt/pick-unsafe_remove_sst_file
branch
from
0ee45a7
to
9197b28
Compare
tabokie
approved these changes
Jun 10, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to pick facebook#7335 and make it work on the tikv/6.4.tikv branch. But there is a lot of difference between these two branches. There will be many conflicts when picking directly and it also lacks the implementation of regardless of function, such as
PrepareOptions.Here is what this PR did:
step 1 implement add ConfigOptions to prepare manually. e959302
step 2 pick bd2c753
step 3 pick a50ea71
step 4 pick 5746767
step 5 Made some minor adjustments like delete unused irrelevant code
Signed-off-by: Xintao hunterlxt@live.com