fix renaming encrypted directory and check compaction paused during checkpoint #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
…ypt-rename Signed-off-by: tabokie <xy.tao@outlook.com>
overvenus
reviewed
Jun 26, 2023
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
changed the title
tonyxuqqi
approved these changes
Jul 7, 2023
overvenus
approved these changes
Jul 7, 2023
Comment on lines
313
to
315
| auto opts = ROCKSDB_NAMESPACE::FlushOptions(); | ||
| opts.check_if_compaction_disabled = true; | ||
| s = db_->Flush(opts, handle); |
There was a problem hiding this comment.
Could you add some comment about the change?
|
/run-test |
Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
May 29, 2024
…heckpoint (tikv#338) * fix renaming encrypted directory Signed-off-by: tabokie <xy.tao@outlook.com> * fix build Signed-off-by: tabokie <xy.tao@outlook.com> * patch test manager Signed-off-by: tabokie <xy.tao@outlook.com> * fix build Signed-off-by: tabokie <xy.tao@outlook.com> * check compaction paused during checkpoint Signed-off-by: tabokie <xy.tao@outlook.com> * add comment Signed-off-by: tabokie <xy.tao@outlook.com> --------- Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 2, 2024
…heckpoint (tikv#338) * fix renaming encrypted directory Signed-off-by: tabokie <xy.tao@outlook.com> * fix build Signed-off-by: tabokie <xy.tao@outlook.com> * patch test manager Signed-off-by: tabokie <xy.tao@outlook.com> * fix build Signed-off-by: tabokie <xy.tao@outlook.com> * check compaction paused during checkpoint Signed-off-by: tabokie <xy.tao@outlook.com> * add comment Signed-off-by: tabokie <xy.tao@outlook.com> --------- Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 2, 2024
…heckpoint (tikv#338) * fix renaming encrypted directory Signed-off-by: tabokie <xy.tao@outlook.com> * fix build Signed-off-by: tabokie <xy.tao@outlook.com> * patch test manager Signed-off-by: tabokie <xy.tao@outlook.com> * fix build Signed-off-by: tabokie <xy.tao@outlook.com> * check compaction paused during checkpoint Signed-off-by: tabokie <xy.tao@outlook.com> * add comment Signed-off-by: tabokie <xy.tao@outlook.com> --------- Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the interface to pass in a hint of physical path.