fix checkpoint again #342
Merged
fix checkpoint again #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
|
/run-test |
overvenus
approved these changes
Jul 25, 2023
tonyxuqqi
reviewed
Jul 25, 2023
| @@ -36,6 +36,9 @@ Status DBImpl::FlushForGetLiveFiles() { | |||
| Status status; | |||
| FlushOptions opts; | |||
| opts.allow_write_stall = true; | |||
| // In TiKV context: If tablet is to be destroyed, its background work will be | |||
| // paused. Manual flush can never make progress. | |||
| opts.check_if_compaction_disabled = true; | |||
There was a problem hiding this comment.
Should all caller of FlushMemTable have this option set?
@tabokie
Signed-off-by: tabokie <xy.tao@outlook.com>
tonyxuqqi
approved these changes
Jul 26, 2023
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified in tikv/tikv#15174.