Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static-metric: fix typos in docstrings #479

Merged
merged 1 commit into from
May 6, 2024
Merged

static-metric: fix typos in docstrings #479

merged 1 commit into from
May 6, 2024

Conversation

eval-exec
Copy link
Contributor

It should be flashable instead of flash able

@lucab lucab changed the title Fix typos static-metric: fix typos in docstrings May 5, 2024
@lucab
Copy link
Member

lucab commented May 5, 2024

@eval-exec thanks for the PR, but the commit needs a Signed-off-by in order to pass CI.

@eval-exec
Fix typos
1e94d44 
It should be `flashable` instead of `flash able`

Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec
Copy link
Contributor Author

@lucab Hello, I added Signed-off-by in the latest commit and force pushed.

lucab
lucab approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, LGTM!

@lucab lucab merged commit f0c9bc2 into tikv:master May 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @lucab